Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape regex in ProjectDeleteModal #8998

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Mar 14, 2024

Description

Slack Thread
containing special regex characters in project name causes page crash

Test Plan

  • Rename project with that includes special characters for regex such as ?, + etc
  • Check if project list page loads without page crash
  • Check if Delete project modal works and project can be removed

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2024
@keita-determined keita-determined marked this pull request as ready for review March 14, 2024 17:15
@keita-determined keita-determined requested a review from a team as a code owner March 14, 2024 17:15
@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9546f28
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f330b440a3070008a4ce7a
😎 Deploy Preview https://deploy-preview-8998--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.76%. Comparing base (978a02e) to head (9546f28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8998      +/-   ##
==========================================
- Coverage   47.49%   42.76%   -4.74%     
==========================================
  Files        1168      848     -320     
  Lines      176315   137041   -39274     
  Branches     2353     2351       -2     
==========================================
- Hits        83742    58603   -25139     
+ Misses      92415    78280   -14135     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ProjectDeleteModal.tsx 0.00% <0.00%> (ø)

... and 320 files with indirect coverage changes

@keita-determined keita-determined merged commit f73fd09 into main Mar 14, 2024
76 of 88 checks passed
@keita-determined keita-determined deleted the fix/escape-regex branch March 14, 2024 18:29
dai-release bot pushed a commit that referenced this pull request Mar 14, 2024
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants