Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: more printing about state of master #9058

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

wes-turner
Copy link
Contributor

Two problems combined into one:

  1. the session that _wait_for_master used had the system's default retry policy (which takes about 15 seconds before it gives up)
  2. _wait_for_master reported every 60 iterations through its loop (which itself was limited by the number of iterations) rather than every 60 seconds. This meant that it only actually reported once every 16 minutes.

CircleCI had been killing workflows that didn't print text after 10 minutes. So when migrations took more than 10 minutes, the whole test would fail.

This PR fixes both of problems (1) and (2).

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (1e6f0f7) to head (5625aaf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9058      +/-   ##
==========================================
- Coverage   49.49%   47.79%   -1.70%     
==========================================
  Files         752     1166     +414     
  Lines      103789   143619   +39830     
  Branches     2386     2384       -2     
==========================================
+ Hits        51374    68648   +17274     
- Misses      52256    74812   +22556     
  Partials      159      159              
Flag Coverage Δ
backend 42.82% <ø> (+8.57%) ⬆️
harness 64.35% <ø> (+<0.01%) ⬆️
web 40.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 415 files with indirect coverage changes

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 5625aaf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66036b1a687cca000849e323

@wes-turner wes-turner marked this pull request as ready for review March 27, 2024 00:57
@wes-turner wes-turner requested a review from a team as a code owner March 27, 2024 00:57
@wes-turner wes-turner merged commit 94e5d21 into main Apr 1, 2024
69 of 81 checks passed
@wes-turner wes-turner deleted the wes/perf-migration-messaging branch April 1, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants