-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loading experiments without filterset #9059
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9059 +/- ##
==========================================
- Coverage 47.80% 41.72% -6.08%
==========================================
Files 1161 841 -320
Lines 143646 104182 -39464
Branches 2373 2373
==========================================
- Hits 68676 43475 -25201
+ Misses 74817 60554 -14263
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything from lines 196 to 203 needs to be in an else clause because we need to handle syncing filterset changes back to the settings store.
(cherry picked from commit 93bca2a)
Description
Looks like
searchExperiments
was not being called because of this conditional:if (isLoadingSettings || Loadable.isNotLoaded(loadableFormset)) return;
.Occurred on any project details page without experiments, but also did not occur when first visiting a page that did have experiments and loaded correctly, then navigating to a page without experiments.
Seems to be addressed by making sure
formStore.init()
is always called, even without data from existingfilterset
.Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket