Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading experiments without filterset #9059

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: loading experiments without filterset #9059

merged 2 commits into from
Mar 27, 2024

Conversation

johnkim-det
Copy link
Contributor

Description

Looks like searchExperiments was not being called because of this conditional:
if (isLoadingSettings || Loadable.isNotLoaded(loadableFormset)) return;.

Occurred on any project details page without experiments, but also did not occur when first visiting a page that did have experiments and loaded correctly, then navigating to a page without experiments.

Seems to be addressed by making sure formStore.init() is always called, even without data from existing filterset.

Test Plan

  1. Visit the project details page for a project with no experiments.
  2. Refresh the page.
  3. Make sure the page displays the "No Experiments" message instead of a loading state.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 41.72%. Comparing base (1868723) to head (f6f2e35).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9059      +/-   ##
==========================================
- Coverage   47.80%   41.72%   -6.08%     
==========================================
  Files        1161      841     -320     
  Lines      143646   104182   -39464     
  Branches     2373     2373              
==========================================
- Hits        68676    43475   -25201     
+ Misses      74817    60554   -14263     
  Partials      153      153              
Flag Coverage Δ
harness ?
web 40.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 11.56% <0.00%> (-0.03%) ⬇️

... and 320 files with indirect coverage changes

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f6f2e35
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66044f1c7793120008aa7eb3
😎 Deploy Preview https://deploy-preview-9059--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnkim-det johnkim-det added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 27, 2024
Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything from lines 196 to 203 needs to be in an else clause because we need to handle syncing filterset changes back to the settings store.

@johnkim-det johnkim-det merged commit 93bca2a into main Mar 27, 2024
69 of 81 checks passed
@johnkim-det johnkim-det deleted the ET-95 branch March 27, 2024 17:50
dai-release bot pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants