Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faster migrations for metrics table #9060

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

azhou-determined
Copy link
Contributor

Description

consolidate and optimize previous migrations landed as part of profiling v2.

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@azhou-determined azhou-determined requested a review from a team as a code owner March 27, 2024 15:19
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2024
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a5fc533
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6604391dcc43d800084ccc4c

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.80%. Comparing base (e8dba6d) to head (a5fc533).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9060      +/-   ##
==========================================
- Coverage   47.80%   47.80%   -0.01%     
==========================================
  Files        1166     1166              
  Lines      143686   143686              
  Branches     2386     2386              
==========================================
- Hits        68690    68687       -3     
- Misses      74837    74840       +3     
  Partials      159      159              
Flag Coverage Δ
backend 42.86% <ø> (-0.01%) ⬇️
harness 64.32% <ø> (ø)
web 40.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@azhou-determined azhou-determined changed the title chore: faster migrations for metrics table fix: faster migrations for metrics table Mar 27, 2024
@azhou-determined azhou-determined merged commit a07f0fb into main Mar 27, 2024
74 of 90 checks passed
@azhou-determined azhou-determined deleted the profiling-faster-migrations branch March 27, 2024 16:08
@azhou-determined azhou-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 27, 2024
dai-release bot pushed a commit that referenced this pull request Mar 27, 2024
optimize migrations on metrics table (landed as part of #9032)

(cherry picked from commit a07f0fb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants