Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop showing loading indicator in queued state #9081

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Apr 1, 2024

Description

https://hpe-aiatscale.slack.com/archives/CLCE8D998/p1711644073872369

Test Plan

  • Check if loading indicator is not visible in queued state in single and multi trials experiments
  • Check if no regressions with other states such as running, stop etc

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Apr 1, 2024
@keita-determined keita-determined marked this pull request as ready for review April 1, 2024 18:17
@keita-determined keita-determined requested a review from a team as a code owner April 1, 2024 18:17
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9bfcdef
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660afa33e8bbd30008637daa
😎 Deploy Preview https://deploy-preview-9081--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.58%. Comparing base (5031807) to head (9bfcdef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9081      +/-   ##
==========================================
- Coverage   47.06%   40.58%   -6.48%     
==========================================
  Files        1154      832     -322     
  Lines      142374   103109   -39265     
  Branches     2423     2423              
==========================================
- Hits        67009    41848   -25161     
+ Misses      75175    61071   -14104     
  Partials      190      190              
Flag Coverage Δ
harness ?
web 38.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/ExperimentDetails/ExperimentVisualization.tsx 0.00% <0.00%> (ø)

... and 322 files with indirect coverage changes

@keita-determined keita-determined merged commit 37abc6c into main Apr 1, 2024
73 of 85 checks passed
@keita-determined keita-determined deleted the fix/stop-showing-loading-in-queue branch April 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants