-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Bun to fix race condition in tests [DET-10193] #9082
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9082 +/- ##
==========================================
- Coverage 47.07% 47.05% -0.02%
==========================================
Files 1155 1155
Lines 142400 142400
Branches 2421 2423 +2
==========================================
- Hits 67034 67009 -25
- Misses 75176 75201 +25
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
does this also apply to RM-57?
957c69f
to
67768d2
Compare
Description
Applies actual fix by upgrading bun to a version where the race isn't an issue
https://app.circleci.com/pipelines/github/determined-ai/determined/53322/workflows/afff1432-f6d9-4aa2-ae88-be17e7f69e46/jobs/2405408
Test Plan
Looped intg a bunch
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket