Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Bun to fix race condition in tests [DET-10193] #9082

Merged
merged 13 commits into from
Apr 4, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Apr 1, 2024

Description

Applies actual fix by upgrading bun to a version where the race isn't an issue

https://app.circleci.com/pipelines/github/determined-ai/determined/53322/workflows/afff1432-f6d9-4aa2-ae88-be17e7f69e46/jobs/2405408

Test Plan

Looped intg a bunch

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Apr 1, 2024
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 67768d2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660d63e38f64900008527452
😎 Deploy Preview https://deploy-preview-9082--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.05%. Comparing base (f78b9aa) to head (67768d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9082      +/-   ##
==========================================
- Coverage   47.07%   47.05%   -0.02%     
==========================================
  Files        1155     1155              
  Lines      142400   142400              
  Branches     2421     2423       +2     
==========================================
- Hits        67034    67009      -25     
- Misses      75176    75201      +25     
  Partials      190      190              
Flag Coverage Δ
backend 42.88% <ø> (-0.06%) ⬇️
harness 64.07% <ø> (ø)
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey changed the title Nickb flake look into chore: upgrade Bun to fix race condition in tests Apr 2, 2024
@NicholasBlaskey NicholasBlaskey changed the title chore: upgrade Bun to fix race condition in tests chore: upgrade Bun to fix race condition in tests [DET-10193] Apr 2, 2024
@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review April 2, 2024 13:57
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner April 2, 2024 13:57
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
does this also apply to RM-57?

@NicholasBlaskey NicholasBlaskey merged commit b8bf396 into main Apr 4, 2024
69 of 81 checks passed
@NicholasBlaskey NicholasBlaskey deleted the nickb_flake_look_into branch April 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants