Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm value for gke tests #9114

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: helm value for gke tests #9114

merged 1 commit into from
Apr 5, 2024

Conversation

amandavialva01
Copy link
Contributor

Description

Fix for e2e gke tests and don't run shared cluster e2e test during nightly (or it'll interfere with the cleanup job)

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@amandavialva01 amandavialva01 requested a review from a team as a code owner April 5, 2024 15:14
@cla-bot cla-bot bot added the cla-signed label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.63%. Comparing base (2ef5ab9) to head (0981fe3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9114   +/-   ##
=======================================
  Coverage   46.63%   46.63%           
=======================================
  Files        1172     1172           
  Lines      143619   143619           
  Branches     2410     2410           
=======================================
  Hits        66983    66983           
  Misses      76431    76431           
  Partials      205      205           
Flag Coverage Δ
backend 43.38% <ø> (ø)
harness 63.99% <ø> (ø)
web 37.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0981fe3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6610155943a9d10008f6463a

@amandavialva01 amandavialva01 merged commit 25767b9 into main Apr 5, 2024
90 of 99 checks passed
@amandavialva01 amandavialva01 deleted the amanda/fixGkeTests branch April 5, 2024 15:51
@amandavialva01 amandavialva01 mentioned this pull request Apr 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants