fix: unlock mutex for experiment ResourcePool() [RM-152]

[carolinaecalderon]

Ticket

RM-152

Description

Unlock the internal experiment mutex in ResourcePool()

Test Plan

I added a unit test that checks that the function returns smoothly. Without my change, the test would timeout anyway/fail.

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

[netlify]

✅ Deploy Preview for determined-ui canceled.

Name	Link
🔨 Latest commit	5ff2388
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/661432705c73bd00087f5b0f

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (cf2f2be) to head (5ff2388).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9119   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files        1174     1174           
  Lines      145186   145186           
  Branches     2413     2413           
=======================================
+ Hits        67026    67028    +2     
+ Misses      77952    77950    -2     
  Partials      208      208           

Flag	Coverage Δ
backend	43.49% <100.00%> (+<0.01%)	⬆️
harness	64.00% <ø> (ø)
web	36.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
master/internal/experiment_job_service.go	7.50% <100.00%> (+7.50%)	⬆️

... and 3 files with indirect coverage changes

[NicholasBlaskey]

one crazy idea is to try and right a regex that catches

defer *.Unlock() and put it in forbidigo

determined/master/.golangci.yml

Line 77 in 65339d2

forbidigo:

[carolinaecalderon]

note: had to add these changes to satisfy the linter, although my PR doesn't touch this

[tara-det-ai]

suggested edit