Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce time and increase reliability of tests #9125

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 8, 2024

Ticket

Description

This test has been quite flaky and times out quite often. Steps taken to increase reliability:

  • Reduced the time incremented by fake clock in each test
  • Moved time to just after midnight instead of midnight on the dot to avoid syncronization issues
  • Reduced the default log retention days.

Test Plan

Ran each test locally a 100 times. The average time of each tests are:

  • TestScheduleRetentionNoConfig: 0.71s
  • TestScheduleRetention100Days: 1.79s
  • TestScheduleRetentionNeverExpire: 5.07s

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a6dcfba
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66145efcf819420008c605ef

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (cf2f2be) to head (a6dcfba).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9125      +/-   ##
==========================================
- Coverage   46.16%   46.16%   -0.01%     
==========================================
  Files        1174     1174              
  Lines      145186   145186              
  Branches     2413     2413              
==========================================
- Hits        67026    67024       -2     
- Misses      77952    77954       +2     
  Partials      208      208              
Flag Coverage Δ
backend 43.48% <ø> (-0.01%) ⬇️
harness 64.00% <ø> (ø)
web 36.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@salonig23 salonig23 marked this pull request as ready for review April 8, 2024 21:23
@salonig23 salonig23 requested a review from a team as a code owner April 8, 2024 21:23
@salonig23 salonig23 changed the title fix: reduce time and reliability of tests fix: reduce time and increase reliability of tests Apr 8, 2024
Copy link
Contributor

@erikwilson erikwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salonig23 salonig23 merged commit c89b3df into main Apr 8, 2024
80 of 92 checks passed
@salonig23 salonig23 deleted the fix-retention-tests branch April 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants