Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent table breaking on null columnWidths [ET-161] #9131

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Apr 9, 2024

Ticket

Description

Test Plan

  • Reset user settings in settings drawer
  • select few experiments and open compare view
  • click around for a few seconds and make sure you're able to interact with table UI

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 399c428
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66153a1ab0102400084afbf3
😎 Deploy Preview https://deploy-preview-9131--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.53%. Comparing base (d5f807d) to head (399c428).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9131      +/-   ##
==========================================
- Coverage   46.16%   39.53%   -6.64%     
==========================================
  Files        1174      852     -322     
  Lines      145186   105820   -39366     
  Branches     2412     2413       +1     
==========================================
- Hits        67025    41831   -25194     
+ Misses      77953    63781   -14172     
  Partials      208      208              
Flag Coverage Δ
harness ?
web 36.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t/src/pages/F_ExpList/F_ExperimentList.settings.ts 100.00% <100.00%> (ø)

... and 322 files with indirect coverage changes

@EmilyBonar EmilyBonar merged commit 133f838 into main Apr 9, 2024
76 of 88 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/settings-freeze-table branch April 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants