test: fix logging test typehint syntax error for py38 #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
hamidzr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9142 +/- ##
==========================================
- Coverage 46.94% 46.20% -0.75%
==========================================
Files 755 1175 +420
Lines 104809 145341 +40532
Branches 2414 2414
==========================================
+ Hits 49201 67149 +17948
- Misses 55399 77983 +22584
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
NicholasBlaskey
approved these changes
Apr 10, 2024
maxrussell
approved these changes
Apr 10, 2024
|
github outage? |
|
please merge with this title if you can: Merge attempt failed |
hamidzr
added
the
to-cherry-pick
|
this is a test only change but I marked it to be cherry picked because I assume it'd affect the release branch tests |
dai-release bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 3f7a396)
hamidzr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
py 3.8 is not happy with re.Pattern[str]
Test Plan
intentional failures https://app.circleci.com/pipelines/github/determined-ai/determined/53837/workflows/64c6bb5a-d27e-44ec-9846-58f58754474e
Checklist
docs/release-notes/.See Release Note for details.