ci: publish-docs installs awscli into user space #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #9126 removing the awscli installation was not well tested and doesn't work in production. This adds it back, but explicitly adds it to the user path so that the pip doesn't complain about installation into a system-managed python path.
wes-turner
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9153 +/- ##
==========================================
- Coverage 45.70% 42.01% -3.69%
==========================================
Files 1179 1042 -137
Lines 146771 135762 -11009
Branches 2419 2419
==========================================
- Hits 67077 57043 -10034
+ Misses 79480 78505 -975
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9126 removing the awscli installation was not well tested and doesn't work in production. This adds it back, but explicitly adds it to the user path so that the pip doesn't complain about installation into a system-managed python path.
MD-349
Ticket
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.