Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: louden server errors coming from deleteCheckpoints #9184

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Apr 17, 2024

Ticket

ET-169

Description

Server errors are silenced by default in production -- this pr undoes that for the server errors coming from deletecheckpoints.

Test Plan

same as #9178

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@ashtonG ashtonG requested a review from a team as a code owner April 17, 2024 21:32
@cla-bot cla-bot bot added the cla-signed label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e44d12d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66203fec1145440008f4ec09
😎 Deploy Preview https://deploy-preview-9184--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 38.69%. Comparing base (26f5e0b) to head (e44d12d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9184      +/-   ##
==========================================
- Coverage   45.45%   38.69%   -6.77%     
==========================================
  Files        1197      875     -322     
  Lines      147628   108230   -39398     
  Branches     2438     2438              
==========================================
- Hits        67109    41882   -25227     
+ Misses      80287    66116   -14171     
  Partials      232      232              
Flag Coverage Δ
harness ?
web 35.41% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/CheckpointModal.tsx 19.60% <25.00%> (-0.30%) ⬇️
.../pages/ExperimentDetails/ExperimentCheckpoints.tsx 13.49% <25.00%> (-0.10%) ⬇️

... and 322 files with indirect coverage changes

@ashtonG ashtonG merged commit 371c90b into main Apr 17, 2024
76 of 90 checks passed
@ashtonG ashtonG deleted the fix/delete-checkpoints-silent-error branch April 17, 2024 21:41
dai-release bot pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants