Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix a test util issue with master config schema assumptions #9193

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Apr 18, 2024

Ticket

Description

a skip logic running on slurm tests would fail due to resource_pools being explicitly set to null
failure report https://hpe-aiatscale.slack.com/archives/C04C9JXB1C2/p1713371230944499

Test Plan

add the ci label and check slurm tests run and pass https://app.circleci.com/pipelines/github/determined-ai/determined?branch=hz-config-check

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6749af1
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66214b419042a200072df1b1

@hamidzr hamidzr changed the title tests: fix a test util issue with master config schema assumptions test: fix a test util issue with master config schema assumptions Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.73%. Comparing base (dd7f4b5) to head (6749af1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9193      +/-   ##
==========================================
- Coverage   45.92%   40.73%   -5.19%     
==========================================
  Files         777      640     -137     
  Lines      107000    95984   -11016     
  Branches     2437     2438       +1     
==========================================
- Hits        49137    39101   -10036     
+ Misses      57631    56651     -980     
  Partials      232      232              
Flag Coverage Δ
harness 53.50% <ø> (-10.52%) ⬇️
web 35.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 200 files with indirect coverage changes

@hamidzr hamidzr marked this pull request as ready for review April 18, 2024 18:08
@hamidzr hamidzr requested a review from a team as a code owner April 18, 2024 18:08
@hamidzr hamidzr merged commit 4b1c937 into main Apr 18, 2024
81 of 99 checks passed
@hamidzr hamidzr deleted the hz-config-check branch April 18, 2024 20:35
JComins000 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants