Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: can't launch NSC test assert 404 instead of 403 #9197

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Apr 18, 2024

Ticket

Description

Fix failing test after this
#9140

Notebooks, tensorboards, shells and commands should return 404 trying to launch a workspace you don't have access to.

Test Plan

test passes

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner April 18, 2024 19:59
@cla-bot cla-bot bot added the cla-signed label Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c3f3496
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/662181cc9693ee0008a5f4d3

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.24%. Comparing base (2ced9b9) to head (cf861a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9197      +/-   ##
==========================================
- Coverage   45.89%   36.24%   -9.65%     
==========================================
  Files         777      602     -175     
  Lines      107072    94206   -12866     
  Branches     2439     2438       -1     
==========================================
- Hits        49140    34148   -14992     
- Misses      57700    59826    +2126     
  Partials      232      232              
Flag Coverage Δ
harness 38.56% <ø> (-25.46%) ⬇️
web 35.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 273 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey merged commit 5f312ed into main Apr 18, 2024
67 of 88 checks passed
@NicholasBlaskey NicholasBlaskey deleted the rbac_ntsc_fix_404 branch April 18, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants