Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add determined-ee context to python ee publish #9234

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

dannysauer
Copy link
Member

@dannysauer dannysauer commented Apr 24, 2024

Ticket

Description

The EE python publish job uses different credentials to publish to fury.io which are in the determined-ee context

Test Plan

Make an RC and see what happens!

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

The EE python publish job uses different credentials to publish to fury.io which are in the determined-ee context
@dannysauer dannysauer requested a review from a team as a code owner April 24, 2024 14:36
@cla-bot cla-bot bot added the cla-signed label Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit db8c14c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6629190df8dbf90008651acf

@dannysauer dannysauer changed the title Add determined-ee context to python ee publish ci: add determined-ee context to python ee publish Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.35%. Comparing base (be02802) to head (db8c14c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9234      +/-   ##
==========================================
- Coverage   44.70%   40.35%   -4.35%     
==========================================
  Files        1270      755     -515     
  Lines      155186   105816   -49370     
  Branches     2436     2435       -1     
==========================================
- Hits        69371    42699   -26672     
+ Misses      85579    62881   -22698     
  Partials      236      236              
Flag Coverage Δ
backend 34.27% <ø> (-7.31%) ⬇️
harness 49.63% <ø> (-14.69%) ⬇️
web 35.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 647 files with indirect coverage changes

@carolinaecalderon carolinaecalderon added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 24, 2024
@dannysauer
Copy link
Member Author

Not waiting for CI, since the changed test doesn't run in normal CI anyway. Infra and Release-captain approved. :)

@dannysauer dannysauer merged commit f8d26a8 into main Apr 24, 2024
72 of 102 checks passed
@dannysauer dannysauer deleted the ci/dannys/update-python-fury-job branch April 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants