Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hew update for select bug in log viewer #9249

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Apr 25, 2024

Ticket

ET-118

Description

select component in log viewer bug

Test Plan

  • Check if the select component height doesnt change after selecting item in log viewer (see the ticket for more details)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 25, 2024
@keita-determined keita-determined added to-cherry-pick Pull requests that need to be cherry-picked into the current release and removed cla-signed labels Apr 25, 2024
@keita-determined keita-determined marked this pull request as ready for review April 25, 2024 22:52
@keita-determined keita-determined requested a review from a team as a code owner April 25, 2024 22:52
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 74069c6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/662ade90de480e0008049189
😎 Deploy Preview https://deploy-preview-9249--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.01%. Comparing base (95e4257) to head (74069c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9249      +/-   ##
==========================================
- Coverage   44.71%   38.01%   -6.71%     
==========================================
  Files        1270      946     -324     
  Lines      155328   115669   -39659     
  Branches     2436     2436              
==========================================
- Hits        69460    43966   -25494     
+ Misses      85632    71467   -14165     
  Partials      236      236              
Flag Coverage Δ
harness ?
web 35.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@keita-determined keita-determined merged commit f4d0466 into main Apr 26, 2024
93 of 105 checks passed
@keita-determined keita-determined deleted the fix/log-select-bug branch April 26, 2024 16:37
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants