Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop publishing helm charts to NGC. #9271

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: stop publishing helm charts to NGC. #9271

merged 1 commit into from
Apr 30, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Apr 30, 2024

Description

Publishing helm charts to NGC is useless. Publishing to https://helm.determined.ai is done elsewhere.

https://hpe-aiatscale.slack.com/archives/C03JGLKTBEJ/p1714429971196879
https://hpe-aiatscale.slack.com/archives/C7E6HPZ5F/p1714432108065479

Test Plan

This is changing CI jobs for release which we have no way to test or dry-run. Please review carefully.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@ioga ioga requested a review from a team as a code owner April 30, 2024 17:19
@ioga ioga requested a review from loksonarius April 30, 2024 17:19
@cla-bot cla-bot bot added the cla-signed label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4fc65a8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6631282ee06cc500083aad8d

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.58%. Comparing base (f8f8672) to head (4fc65a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9271      +/-   ##
==========================================
- Coverage   44.59%   44.58%   -0.02%     
==========================================
  Files        1273     1273              
  Lines      155832   155832              
  Branches     2439     2439              
==========================================
- Hits        69498    69472      -26     
- Misses      86095    86121      +26     
  Partials      239      239              
Flag Coverage Δ
backend 41.68% <ø> (-0.06%) ⬇️
harness 64.05% <ø> (ø)
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@ioga ioga merged commit a611cf0 into main Apr 30, 2024
92 of 106 checks passed
@ioga ioga deleted the ngc-helm branch April 30, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants