-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display Log retention days and Remaining log retention days in Logs Tab #9305
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
066a505
to
8906af2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9305 +/- ##
===========================================
- Coverage 48.10% 42.02% -6.09%
===========================================
Files 1219 515 -704
Lines 157878 50557 -107321
Branches 2730 0 -2730
===========================================
- Hits 75954 21247 -54707
+ Misses 81749 29310 -52439
+ Partials 175 0 -175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8906af2
to
4d5752f
Compare
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
4d5752f
to
65e84a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Go/backend side of this looks good to me -- less sure about the web UI side of things, especially Keita's comment about the Button element.
65e84a4
to
3251967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments, but lets talk about it when we huddle
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
14e0a76
to
da6a026
Compare
webui/react/src/components/RemainingRetentionDaysLabelComponent.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/components/RemainingRetentionDaysLabelComponent.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/components/RemainingRetentionDaysLabelComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good
webui/react/src/components/RemainingRetentionDaysLabelComponent.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
webui/react/src/pages/ExperimentDetails/ExperimentSingleTrialTabs.tsx
Outdated
Show resolved
Hide resolved
88d077f
to
627d2dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the PR title? its truncated.
CI is failing
other than that lgtm
627d2dd
to
e833132
Compare
Ticket
DET-10242
Description
In the Trials Overview page added a "Log Retention Days" field.
In the logs tab, added a small tag that shows the number of days remaining to retain the logs
Test Plan
det e create const.yaml . --config "retention_policy.log_retention_days=100"
Checklist
docs/release-notes/
.See Release Note for details.