Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run requests-hpc-tests on main #9308

Merged
merged 1 commit into from
May 3, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 3, 2024

Ticket

Description

HPC approval is just spinning on main

https://github.com/determined-ai/determined/runs/24565380530

Stop this in the future

Test Plan

no testing

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner May 3, 2024 20:17
@cla-bot cla-bot bot added the cla-signed label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit dc80032
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66354655a100830008893f4e

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (4c314a2) to head (dc80032).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9308      +/-   ##
==========================================
+ Coverage   44.24%   44.63%   +0.38%     
==========================================
  Files        1275     1275              
  Lines      156260   156261       +1     
  Branches     2449     2450       +1     
==========================================
+ Hits        69144    69740     +596     
+ Misses      86876    86281     -595     
  Partials      240      240              
Flag Coverage Δ
backend 41.83% <ø> (+<0.01%) ⬆️
harness 64.08% <ø> (+1.48%) ⬆️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@NicholasBlaskey NicholasBlaskey merged commit f9b96fe into main May 3, 2024
86 of 100 checks passed
@NicholasBlaskey NicholasBlaskey deleted the dontrunrequestsonmain branch May 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants