Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run test-e2e-longrunning tests on main #9313

Merged
merged 1 commit into from
May 6, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 6, 2024

Ticket

Description

test-e2e workflows will already have them. test-e2e-longrunning is pure duplication on main.

Test Plan

See if main is still running these after this lands

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner May 6, 2024 17:45
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f5d3fbd
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66391749fc74bc00083e9045

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (9cab46d) to head (f5d3fbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9313   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files        1275     1275           
  Lines      156285   156285           
  Branches     2449     2449           
=======================================
+ Hits        69756    69757    +1     
+ Misses      86289    86288    -1     
  Partials      240      240           
Flag Coverage Δ
backend 41.82% <ø> (+<0.01%) ⬆️
harness 64.09% <ø> (-0.01%) ⬇️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Contributor

@davidfluck-hpe davidfluck-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a quick question to verify, though: the PR title/description talk about not running these specific tests on main, but the filter anchor also includes /pull\/.*/ and /release-.*/ regexes. Is that desired?

@NicholasBlaskey
Copy link
Contributor Author

Looks good. Just a quick question to verify, though: the PR title/description talk about not running these specific tests on main, but the filter anchor also includes /pull\/.*/ and /release-.*/ regexes. Is that desired?

Yeah most other tests follow this pattern. The ones that weren't gated to *upstream-feature-branch are an exception. If we do want to change how the release runs test it should be all of them.

@davidfluck-hpe
Copy link
Contributor

Ah, I see. Thanks!

@NicholasBlaskey NicholasBlaskey merged commit a76c549 into main May 6, 2024
90 of 103 checks passed
@NicholasBlaskey NicholasBlaskey deleted the dont_run_test_e2e_longrunning_on_main branch May 6, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants