Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter batch action experiments #9316

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented May 6, 2024

Ticket

https://hpe-aiatscale.slack.com/archives/CLCE8D998/p1715014499179449?thread_ts=1715008712.981189&cid=CLCE8D998

Description

API requests for batch actions should only contain experiment ids for selected experiments where the action is valid.

Test Plan

  • On Experiments List, select two experiments which would not have the same action valid (for example, one completed experiment and one paused experiment).
  • Select the bulk action (for example, resume), and confirm in the modal that appears.
  • Should see a toast that confirms successful action on one experiment, not two. Can also confirm by looking at payload sent in action's API request, which should only contain the one valid experiment ID.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@johnkim-det johnkim-det requested a review from a team as a code owner May 6, 2024 20:38
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit bef2bc5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66393fb93882e80008263664
😎 Deploy Preview https://deploy-preview-9316--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 37.97%. Comparing base (a76c549) to head (bef2bc5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9316      +/-   ##
==========================================
- Coverage   44.63%   37.97%   -6.66%     
==========================================
  Files        1275      951     -324     
  Lines      156285   116464   -39821     
  Branches     2450     2449       -1     
==========================================
- Hits        69757    44230   -25527     
+ Misses      86288    71994   -14294     
  Partials      240      240              
Flag Coverage Δ
harness ?
web 35.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/TableActionBar.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add test plans?

@carolinaecalderon carolinaecalderon added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label May 7, 2024
@johnkim-det johnkim-det merged commit 5b73dc4 into main May 7, 2024
91 of 104 checks passed
@johnkim-det johnkim-det deleted the fix/filter-batch-actions branch May 7, 2024 13:28
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants