-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update npm libraries #9331
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
onAction?: (action: T) => void; | ||
onClear?: () => void; | ||
selectedRowCount?: number; | ||
} | ||
|
||
const defaultProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to resolve Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
, removed defaultProps
and use JS default parameters
map.update( | ||
resourcePool, | ||
(oldWorkspaceIds) => oldWorkspaceIds?.filter((id) => !workspaceIds.includes(id)), | ||
map.update(resourcePool, (oldWorkspaceIds) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just format change
5fbbdf1
to
bd23a46
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9331 +/- ##
==========================================
- Coverage 45.14% 38.75% -6.39%
==========================================
Files 1230 902 -328
Lines 154472 113993 -40479
Branches 2404 2403 -1
==========================================
- Hits 69738 44182 -25556
+ Misses 84539 69620 -14919
+ Partials 195 191 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
could you capture the |
added in test plan |
re: test plan -- remember that members of the release party should be using this test plan to ensure that the pr works. can we succinctly describe the change in logic here and find a place in the app where users can observe the change happening? |
bd23a46
to
4564c59
Compare
@ashtonG reverted |
Ticket
ET-244
Description
Updated libraries that dont require many code changes, so avoided updating antd, testing-library, uplot, ESLint etc
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.