Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update npm libraries #9331

Merged
merged 3 commits into from
May 14, 2024
Merged

chore: update npm libraries #9331

merged 3 commits into from
May 14, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented May 8, 2024

Ticket

ET-244

Description

Updated libraries that dont require many code changes, so avoided updating antd, testing-library, uplot, ESLint etc

Test Plan

  • CI pass
  • no regressions

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit cb31de7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66429c66ecd8660008386fc5
😎 Deploy Preview https://deploy-preview-9331--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

onAction?: (action: T) => void;
onClear?: () => void;
selectedRowCount?: number;
}

const defaultProps = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to resolve Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead., removed defaultProps and use JS default parameters

map.update(
resourcePool,
(oldWorkspaceIds) => oldWorkspaceIds?.filter((id) => !workspaceIds.includes(id)),
map.update(resourcePool, (oldWorkspaceIds) =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just format change

@keita-determined keita-determined force-pushed the chore/update-libraries branch 2 times, most recently from 5fbbdf1 to bd23a46 Compare May 8, 2024 00:52
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 38.75%. Comparing base (f91c2a3) to head (cb31de7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9331      +/-   ##
==========================================
- Coverage   45.14%   38.75%   -6.39%     
==========================================
  Files        1230      902     -328     
  Lines      154472   113993   -40479     
  Branches     2404     2403       -1     
==========================================
- Hits        69738    44182   -25556     
+ Misses      84539    69620   -14919     
+ Partials      195      191       -4     
Flag Coverage Δ
harness ?
web 36.38% <28.57%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/Section.tsx 100.00% <100.00%> (ø)
webui/react/src/components/Table/TableBatch.tsx 28.00% <0.00%> (-6.94%) ⬇️
webui/react/src/components/JupyterLabModal.tsx 84.61% <0.00%> (ø)
webui/react/src/stores/cluster.tsx 37.86% <0.00%> (+0.12%) ⬆️

... and 328 files with indirect coverage changes

@keita-determined keita-determined marked this pull request as ready for review May 8, 2024 01:05
@keita-determined keita-determined requested a review from a team as a code owner May 8, 2024 01:05
@ashtonG
Copy link
Contributor

ashtonG commented May 10, 2024

could you capture the humanize-duration change in a testing plan, please?

@keita-determined
Copy link
Contributor Author

could you capture the humanize-duration change in a testing plan, please?

added in test plan

@ashtonG
Copy link
Contributor

ashtonG commented May 13, 2024

re: test plan -- remember that members of the release party should be using this test plan to ensure that the pr works. can we succinctly describe the change in logic here and find a place in the app where users can observe the change happening?

@keita-determined
Copy link
Contributor Author

@ashtonG reverted humanize-duration version change not to have test code change in this PR

@keita-determined keita-determined merged commit 4f180db into main May 14, 2024
84 of 97 checks passed
@keita-determined keita-determined deleted the chore/update-libraries branch May 14, 2024 17:28
kkunapuli pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants