Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options in flat run #9341

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented May 8, 2024

Ticket

ET-229

Description

Add table settings menu, and removed dead code (infinite scroll is removed permanently)

Test Plan

  • Enable Flat Run table
  • Check if row height changes by changing option settings and the settings should persist

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 8, 2024
@keita-determined keita-determined marked this pull request as ready for review May 8, 2024 21:35
@keita-determined keita-determined requested a review from a team as a code owner May 8, 2024 21:35
Copy link

netlify bot commented May 8, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a3a6c82
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66426c2026e3cb0009816106
😎 Deploy Preview https://deploy-preview-9341--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 38.56%. Comparing base (16a3f3b) to head (a3a6c82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9341      +/-   ##
==========================================
- Coverage   45.14%   38.56%   -6.59%     
==========================================
  Files        1230      906     -324     
  Lines      154567   114609   -39958     
  Branches     2404     2405       +1     
==========================================
- Hits        69783    44196   -25587     
+ Misses      84589    70218   -14371     
  Partials      195      195              
Flag Coverage Δ
harness ?
web 36.05% <12.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/OptionsMenu.settings.ts 100.00% <100.00%> (ø)
webui/react/src/components/UserSettings.tsx 83.81% <100.00%> (-1.14%) ⬇️
webui/react/src/components/OptionsMenu.tsx 65.75% <66.66%> (+12.97%) ⬆️
webui/react/src/components/Searches/Searches.tsx 0.00% <0.00%> (ø)
webui/react/src/components/TableActionBar.tsx 0.00% <0.00%> (ø)
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% <0.00%> (ø)
webui/react/src/pages/FlatRuns/FlatRuns.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

@keita-determined keita-determined changed the title Feature/add options in flat run feat: add options in flat run May 8, 2024
Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but otherwise LGTM, probably makes sense to update https://hpe-aiatscale.atlassian.net/browse/ET-259 since you addressed it here?

@keita-determined keita-determined force-pushed the feature/add-options-in-flat-run branch from a75c84d to a3a6c82 Compare May 13, 2024 19:38
@keita-determined
Copy link
Contributor Author

one comment but otherwise LGTM, probably makes sense to update https://hpe-aiatscale.atlassian.net/browse/ET-259 since you addressed it here?

i'll update the ticket. i think it should be still TODO because i didn't refactor code.

@keita-determined keita-determined merged commit 989341c into main May 13, 2024
79 of 96 checks passed
@keita-determined keita-determined deleted the feature/add-options-in-flat-run branch May 13, 2024 20:16
@keita-determined keita-determined restored the feature/add-options-in-flat-run branch May 14, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants