Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: put flaky fix back in [INFENG-694] #9394

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented May 20, 2024

Ticket

INFENG-694

Description

I should've kept this flaky fix in. I was hoping maybe the flake has left with the new devcluster stuff, and I was refactoring at the time anyway.
https://output.circle-artifacts.com/output/job/d1b9d965-1f01-4938-9e21-e4d4da7a0a4b/artifacts/0/webui/react/src/e2e/playwright-report/index.html#?testId=46710bd7f7f3d0299264-de618de281ac4f8610f3

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner May 20, 2024 16:14
@cla-bot cla-bot bot added the cla-signed label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ef1a646
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664b76d91a6a0f0008cbe9d0
😎 Deploy Preview https://deploy-preview-9394--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.93%. Comparing base (0c42ced) to head (ef1a646).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9394      +/-   ##
==========================================
- Coverage   46.17%   39.93%   -6.25%     
==========================================
  Files        1199      876     -323     
  Lines      153415   113551   -39864     
  Branches     2440     2440              
==========================================
- Hits        70844    45346   -25498     
+ Misses      82380    68014   -14366     
  Partials      191      191              
Flag Coverage Δ
harness ?
web 38.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@JComins000 JComins000 merged commit cd33c13 into main May 21, 2024
89 of 102 checks passed
@JComins000 JComins000 deleted the jcom/INFENG-694/e2e-flaky branch May 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants