-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove confusing slurm-related code #9417
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9417 +/- ##
=======================================
Coverage 48.61% 48.61%
=======================================
Files 1233 1233
Lines 158958 158958
Branches 2778 2777 -1
=======================================
Hits 77282 77282
Misses 81502 81502
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less confusion is more better.
gonna, as usual, land over unrelated failures |
Ticket
Description
This code clones dev-scripts to get slurmcluster. Unfortunately there are two things named slurmcluster and it doesn't need the one (the gcp slurm tests run
make -C tools/slurm slurmcluster
which lives entirely within the repo).Test Plan
Needs no tests.
Checklist
docs/release-notes/
.See Release Note for details.