Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont utilize the default efs mount on normal aws deploys #9437

Merged
merged 1 commit into from
May 28, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented May 28, 2024

Ticket

Description

Normal det deploys were broken with this default set. It didn't seem necessary in the original PR, but we had to unset this again to not pollute other deploys.

This caused the parameter to leak into normal aws deploys which isn't valid

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@tayritenour tayritenour added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label May 28, 2024
@tayritenour tayritenour requested a review from hamidzr May 28, 2024 23:07
@tayritenour tayritenour requested a review from a team as a code owner May 28, 2024 23:07
@cla-bot cla-bot bot added the cla-signed label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit aca169e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/665663a1c2d7d70008c8c4c5

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.60%. Comparing base (9abde37) to head (aca169e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9437      +/-   ##
==========================================
- Coverage   48.60%   48.60%   -0.01%     
==========================================
  Files        1233     1233              
  Lines      158981   158981              
  Branches     2778     2777       -1     
==========================================
- Hits        77268    77267       -1     
- Misses      81539    81540       +1     
  Partials      174      174              
Flag Coverage Δ
backend 42.14% <ø> (-0.01%) ⬇️
harness 64.02% <ø> (ø)
web 44.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/aws/cli.py 16.86% <ø> (ø)

... and 4 files with indirect coverage changes

@tayritenour tayritenour requested a review from ioga May 28, 2024 23:13
@tayritenour tayritenour enabled auto-merge (squash) May 28, 2024 23:16
@tayritenour tayritenour merged commit b96ccba into main May 28, 2024
91 of 104 checks passed
@tayritenour tayritenour deleted the remove_default_for_cli branch May 28, 2024 23:41
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants