Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken nvidia anchor link #9441

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 29, 2024

Ticket

Description

Test Plan

Fix broken nvidia docs anchor link that was causing the failure here
https://app.circleci.com/pipelines/github/determined-ai/determined/56214/workflows/95c194ec-c163-4a2d-abc3-ef8ce7650c3b/jobs/2617218

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 29, 2024
@determined-ci determined-ci requested a review from a team May 29, 2024 15:09
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 29, 2024
@@ -164,6 +164,7 @@ def setup(app):
# linkcheck gets confused by anchors sometimes
linkcheck_anchors_ignore = [
"install-nvidia-device-plugin",
"on-a-multi-user-system",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is required, added it just in case

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

1 similar comment
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

netlify bot commented May 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ba961b8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6657451ebe6dc300083d5061

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) May 29, 2024 15:14
@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) May 29, 2024 15:15
@NicholasBlaskey NicholasBlaskey merged commit cf22597 into main May 29, 2024
85 of 101 checks passed
@NicholasBlaskey NicholasBlaskey deleted the docs_fix_nvidia_link branch May 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants