Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin huggingface version to <0.23.0 #9483

Merged
merged 6 commits into from
Jun 10, 2024
Merged

fix: pin huggingface version to <0.23.0 #9483

merged 6 commits into from
Jun 10, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Jun 6, 2024

Ticket

MD-419

Description

Fix flakes in test-e2e-gpu-distributed

Test Plan

CI tests pass, especially the test-e2e-gpu-distributed

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 83cb741
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66671c99453f850008c9a58d

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (418525e) to head (83cb741).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9483      +/-   ##
==========================================
- Coverage   49.00%   49.00%   -0.01%     
==========================================
  Files        1234     1234              
  Lines      159699   159699              
  Branches     2781     2781              
==========================================
- Hits        78261    78257       -4     
- Misses      81263    81267       +4     
  Partials      175      175              
Flag Coverage Δ
backend 43.78% <ø> (-0.01%) ⬇️
harness 64.04% <ø> (-0.01%) ⬇️
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@@ -1 +1,3 @@
pip install diffusers["training"]==0.5.1 transformers==4.21.3 ftfy==6.1.1 setuptools==59.5.0 accelerate==0.12.0
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@gt2345 gt2345 merged commit a5cf959 into main Jun 10, 2024
84 of 97 checks passed
@gt2345 gt2345 deleted the gt/hf-nightly branch June 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants