-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Searches view fixes (ET-297) #9487
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9487 +/- ##
==========================================
- Coverage 51.06% 43.78% -7.29%
==========================================
Files 747 423 -324
Lines 111167 71203 -39964
Branches 2778 2779 +1
==========================================
- Hits 56772 31176 -25596
+ Misses 54220 39852 -14368
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Ticket
ET-297
Description
Addresses feedback from Searches View acceptance meeting and other issues
FlatRuns
related to the handling of thepage
param. Changing pagination inFlatRuns
to match how its handled inF_ExperimentList
to avoid this issueTest Plan
Checklist
docs/release-notes/
.See Release Note for details.