-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improving SearchRuns performance when doing hyperparameter filtering #9489
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9489 +/- ##
==========================================
- Coverage 48.97% 48.96% -0.01%
==========================================
Files 1238 1238
Lines 160512 160523 +11
Branches 2784 2784
==========================================
- Hits 78609 78603 -6
- Misses 81728 81745 +17
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for improving this performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
performance test changes look good to me!
Ticket
ET-88
Description
Improving SearchRuns performance when doing hyperparameter filtering. Introducing indexes on hyperparameter name and values, as well as the run id
Test Plan
Performance improvement. Existing tests should pass
Checklist
docs/release-notes/
.See Release Note for details.