Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improving SearchRuns performance when doing hyperparameter filtering #9489

Merged
merged 9 commits into from
Jun 17, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jun 10, 2024

Ticket

ET-88

Description

Improving SearchRuns performance when doing hyperparameter filtering. Introducing indexes on hyperparameter name and values, as well as the run id

Test Plan

Performance improvement. Existing tests should pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 2aec37c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666b47fc4fc56200086dd72f

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (86e6b68) to head (2aec37c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9489      +/-   ##
==========================================
- Coverage   48.97%   48.96%   -0.01%     
==========================================
  Files        1238     1238              
  Lines      160512   160523      +11     
  Branches     2784     2784              
==========================================
- Hits        78609    78603       -6     
- Misses      81728    81745      +17     
  Partials      175      175              
Flag Coverage Δ
backend 43.80% <45.45%> (-0.03%) ⬇️
harness 63.85% <ø> (ø)
web 44.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/experiment_filter.go 91.76% <45.45%> (-3.41%) ⬇️

... and 4 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review June 13, 2024 19:08
@AmanuelAaron AmanuelAaron requested review from a team as code owners June 13, 2024 19:08
@AmanuelAaron AmanuelAaron changed the title try subquery and index feat: Improving SearchRuns performance when doing hyperparameter filtering Jun 13, 2024
@AmanuelAaron AmanuelAaron changed the title feat: Improving SearchRuns performance when doing hyperparameter filtering chore: Improving SearchRuns performance when doing hyperparameter filtering Jun 13, 2024
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving this performance

@AmanuelAaron AmanuelAaron requested review from ashtonG and removed request for julian-determined-ai June 17, 2024 13:56
Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performance test changes look good to me!

@AmanuelAaron AmanuelAaron merged commit 6cd7d06 into main Jun 17, 2024
84 of 100 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/search-runs-perf branch June 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants