Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: preparing a homework assignment [TESTENG-3] #9510

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Jun 12, 2024

Ticket

TESTENG-3

Description

no serial for me

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner June 12, 2024 22:03
@cla-bot cla-bot bot added the cla-signed label Jun 12, 2024
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 762e3e7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666b1d523b29e800080b4453
😎 Deploy Preview https://deploy-preview-9510--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.97%. Comparing base (97667c5) to head (762e3e7).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9510      +/-   ##
==========================================
- Coverage   48.98%   43.97%   -5.02%     
==========================================
  Files        1234      910     -324     
  Lines      159823   119788   -40035     
  Branches     2780     2781       +1     
==========================================
- Hits        78291    52671   -25620     
+ Misses      81357    66942   -14415     
  Partials      175      175              
Flag Coverage Δ
harness ?
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

@djanicekpach djanicekpach self-requested a review June 12, 2024 22:27
@JComins000 JComins000 changed the title test: preparing a homework assignment [TESTENG-4] test: preparing a homework assignment [TESTENG-3] Jun 13, 2024
@JComins000 JComins000 merged commit 21ecda5 into main Jun 13, 2024
84 of 97 checks passed
@JComins000 JComins000 deleted the jcom/TESTENG-3/admins-for-everyone branch June 13, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants