Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip webhook regex matching for exp config #9511

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Jun 12, 2024

Ticket

MD-435

Description

Skip webhook log regex match for user submitted config.

Test Plan

e2e test should cover it.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@gt2345 gt2345 requested a review from a team as a code owner June 12, 2024 22:30
@gt2345 gt2345 requested a review from highvelcty June 12, 2024 22:30
@cla-bot cla-bot bot added the cla-signed label Jun 12, 2024
@gt2345 gt2345 requested review from NicholasBlaskey and removed request for highvelcty June 12, 2024 22:30
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 172f89c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/666a219041530f0008691c05

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.98%. Comparing base (8e9067b) to head (172f89c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9511   +/-   ##
=======================================
  Coverage   48.98%   48.98%           
=======================================
  Files        1238     1238           
  Lines      160522   160524    +2     
  Branches     2784     2784           
=======================================
+ Hits        78633    78635    +2     
  Misses      81714    81714           
  Partials      175      175           
Flag Coverage Δ
backend 43.85% <33.33%> (+<0.01%) ⬆️
harness 63.87% <ø> (ø)
web 44.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/logpattern/logpattern.go 57.42% <0.00%> (ø)
master/internal/webhooks/postgres_webhook.go 57.06% <50.00%> (-0.04%) ⬇️

... and 4 files with indirect coverage changes

@gt2345 gt2345 requested a review from AmanuelAaron June 13, 2024 16:41
@gt2345 gt2345 merged commit f9ba7f4 into main Jun 14, 2024
89 of 104 checks passed
@gt2345 gt2345 deleted the gt/435-webhook-log branch June 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants