refactor: remove DataGrid pagination code (ET-259) #9520
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9520 +/- ##
==========================================
- Coverage 49.28% 44.46% -4.83%
==========================================
Files 1242 914 -328
Lines 161442 120705 -40737
Branches 2867 2868 +1
==========================================
- Hits 79574 53673 -25901
+ Misses 81696 66860 -14836
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -1029,7 +1013,7 @@ const FlatRuns: React.FC<Props> = ({ projectId, searchId }) => { | |||
| getHeaderMenuItems={getHeaderMenuItems} | |||
| getRowAccentColor={getRowAccentColor} | |||
| imperativeRef={dataGridRef} | |||
| isPaginated={isPagedView} | |||
| isPaginated | |||
There was a problem hiding this comment.
i know its from hew, but do we wanna remove isPaginated prop or leave it for the potential use case?
There was a problem hiding this comment.
good catch, I think instead of removing the functionality entirely from DataGrid, i'll replace isPaginated with an optional infiniteScroll prop that is false by default. maybe should've implemented it that way in the first place. will make a hew PR and then update this one when that's merged.
Ticket
ET-259
Description
Remove references to
tableViewModeandisPagedViewfor instances ofDataGrid, since infinite scroll has been de-scoped.Test Plan
No feature testing required for release. Should be covered by regression testing of new Experiment List and Searches view/Runs view (behind Flat runs feature flag).
Checklist
docs/release-notes/.See Release Note for details.