Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webui page height #9527

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: webui page height #9527

merged 1 commit into from
Jun 17, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Jun 14, 2024

Ticket

DET-10330

Description

Remove gap at the bottom of webUI pages.

Changed from imageA to imageB (both displayed below).

imageA
pageheight

imageB
pageheightfixed

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.45%. Comparing base (2bce8b6) to head (e4394ad).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9527      +/-   ##
==========================================
- Coverage   49.28%   44.45%   -4.83%     
==========================================
  Files        1242      918     -324     
  Lines      161444   121170   -40274     
  Branches     2867     2868       +1     
==========================================
- Hits        79568    53867   -25701     
+ Misses      81704    67131   -14573     
  Partials      172      172              
Flag Coverage Δ
harness ?
web 44.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e4394ad
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667050ecd901270008ba4dda
😎 Deploy Preview https://deploy-preview-9527--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amandavialva01 amandavialva01 changed the title fix: webui height fix: webui page height Jun 14, 2024
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

could you write more test plans for the release party?

@@ -31,7 +31,7 @@
}
}
&.noScroll {
max-height: 80vh;
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, max-height: 100vh; before the PR change
https://github.com/determined-ai/determined/pull/9261/files#diff-9837b1da4e743b37af6884671455e6ed0376cacec8bee9b149f1c79334a8f8b7R34

Suggested change
height: 100%;
max-height: 100vh;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh gotchya, changed!

Copy link
Contributor

@eecsliu eecsliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! No comment besides what Keita added

@amandavialva01
Copy link
Contributor Author

\o/

could you write more test plans for the release party?

Made a ticket for this and added it to an epic for Improving Internal Documentation that @maxrussell and I created a while back.

@amandavialva01 amandavialva01 merged commit 0f6eb24 into main Jun 17, 2024
85 of 98 checks passed
@amandavialva01 amandavialva01 deleted the page-height-fix branch June 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants