-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webui page height #9527
fix: webui page height #9527
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9527 +/- ##
==========================================
- Coverage 49.28% 44.45% -4.83%
==========================================
Files 1242 918 -324
Lines 161444 121170 -40274
Branches 2867 2868 +1
==========================================
- Hits 79568 53867 -25701
+ Misses 81704 67131 -14573
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/
could you write more test plans for the release party?
@@ -31,7 +31,7 @@ | |||
} | |||
} | |||
&.noScroll { | |||
max-height: 80vh; | |||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, max-height: 100vh;
before the PR change
https://github.com/determined-ai/determined/pull/9261/files#diff-9837b1da4e743b37af6884671455e6ed0376cacec8bee9b149f1c79334a8f8b7R34
height: 100%; | |
max-height: 100vh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh gotchya, changed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! No comment besides what Keita added
52fe6e1
to
e4394ad
Compare
Made a ticket for this and added it to an epic for Improving Internal Documentation that @maxrussell and I created a while back. |
Ticket
DET-10330
Description
Remove gap at the bottom of webUI pages.
Changed from imageA to imageB (both displayed below).
imageA
imageB
Test Plan
CI passes.
Checklist
docs/release-notes/
.See Release Note for details.