Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set cli pwd warning go to stderr #9536

Merged
merged 3 commits into from
Jul 11, 2024
Merged

chore: set cli pwd warning go to stderr #9536

merged 3 commits into from
Jul 11, 2024

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Jun 18, 2024

Ticket

Description

we'd probably want a shared path for all cli warnings. we have deprecation warnings and probably other warning classes as well

or maybe use https://docs.python.org/3/library/exceptions.html#UserWarning ?

Test Plan

det u logout; det e ls > /dev/null

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4155b1f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668c32874af1ec0008392fa9

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (3f7cad6) to head (4155b1f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9536   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files        1255     1255           
  Lines      153086   153089    +3     
  Branches     3230     3230           
=======================================
+ Hits        80958    80967    +9     
+ Misses      71977    71971    -6     
  Partials      151      151           
Flag Coverage Δ
backend 44.00% <ø> (+0.01%) ⬆️
harness 72.77% <80.00%> (+<0.01%) ⬆️
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/common/api/authentication.py 87.50% <100.00%> (+0.12%) ⬆️
harness/determined/cli/user.py 53.23% <0.00%> (ø)

... and 3 files with indirect coverage changes

@hamidzr hamidzr marked this pull request as ready for review June 18, 2024 14:24
@hamidzr hamidzr requested a review from a team as a code owner June 18, 2024 14:24
Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hamidzr hamidzr self-assigned this Jul 8, 2024
@hamidzr hamidzr merged commit d4c50b5 into main Jul 11, 2024
81 of 94 checks passed
@hamidzr hamidzr deleted the hz-pwd-warn branch July 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants