Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: collect det job ci logs only in case of failure #9537

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Jun 18, 2024

Ticket

Description

also ensures the steps run when the tests fail

Test Plan

make the tests fail to see the logs get collected 469c6d6

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@hamidzr hamidzr requested a review from a team as a code owner June 18, 2024 15:34
@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.88%. Comparing base (3f7cad6) to head (c5bb05c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9537   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files        1255     1255           
  Lines      153086   153086           
  Branches     3230     3230           
=======================================
+ Hits        80958    80960    +2     
+ Misses      71977    71975    -2     
  Partials      151      151           
Flag Coverage Δ
backend 44.00% <ø> (+<0.01%) ⬆️
harness 72.76% <ø> (ø)
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c5bb05c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668c32632cb1ba00084fa287
😎 Deploy Preview https://deploy-preview-9537--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamidzr hamidzr enabled auto-merge (squash) July 8, 2024 18:41
@hamidzr hamidzr self-assigned this Jul 8, 2024
@hamidzr hamidzr merged commit 262ad5a into main Jul 8, 2024
80 of 94 checks passed
@hamidzr hamidzr deleted the hz-log-collect branch July 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants