Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ConjunctionContainer test cases #9541

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jun 18, 2024

Ticket

ET-201

Description

Add ConjunctionContainer test cases

Test Plan

  • CI passes
  • coverage should be more than 80% (ConjunctionContainer component)

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@keita-determined keita-determined marked this pull request as ready for review June 18, 2024 23:23
@keita-determined keita-determined requested a review from a team as a code owner June 18, 2024 23:23
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c02e617
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667c5f1c720eb90008a2036b
😎 Deploy Preview https://deploy-preview-9541--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.22%. Comparing base (651264b) to head (93aac11).
Report is 7 commits behind head on main.

Current head 93aac11 differs from pull request most recent head c02e617

Please upload reports for the commit c02e617 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9541      +/-   ##
==========================================
- Coverage   49.80%   45.22%   -4.58%     
==========================================
  Files        1247      923     -324     
  Lines      162243   121910   -40333     
  Branches     2888     2888              
==========================================
- Hits        80805    55137   -25668     
+ Misses      81266    66602   -14664     
+ Partials      172      171       -1     
Flag Coverage Δ
harness ?
web 46.22% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 325 files with indirect coverage changes

@keita-determined keita-determined merged commit b73fbbc into main Jun 26, 2024
77 of 92 checks passed
@keita-determined keita-determined deleted the test/conjunction-container branch June 26, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants