Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code tab to run page [ET-657] #9771

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Jul 31, 2024

Ticket

ET-657

Description

Test Plan

On a single run search the Code tab should be visible.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@EmilyBonar EmilyBonar added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 31, 2024
@EmilyBonar EmilyBonar requested a review from a team as a code owner July 31, 2024 15:05
@cla-bot cla-bot bot added the cla-signed label Jul 31, 2024
@EmilyBonar EmilyBonar requested review from ashtonG and removed request for julian-determined-ai July 31, 2024 15:05
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a6879e4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66aa5f8731f8550008fb9996
😎 Deploy Preview https://deploy-preview-9771--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.87%. Comparing base (935799d) to head (a6879e4).

Files Patch % Lines
webui/react/src/pages/TrialDetails.tsx 95.83% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9771      +/-   ##
==========================================
- Coverage   54.16%   49.87%   -4.30%     
==========================================
  Files        1258      935     -323     
  Lines      154943   125657   -29286     
  Branches     3495     3500       +5     
==========================================
- Hits        83925    62668   -21257     
+ Misses      70872    62843    -8029     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.46% <95.83%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/TrialDetails.tsx 90.80% <95.83%> (+0.74%) ⬆️

... and 323 files with indirect coverage changes

@EmilyBonar EmilyBonar changed the title feat: add code tab to run page [ET-657] feat: add code tab to run page [ET-657] Jul 31, 2024
webui/react/src/pages/TrialDetails.tsx Outdated Show resolved Hide resolved
webui/react/src/pages/TrialDetails.tsx Outdated Show resolved Hide resolved
Co-authored-by: Ashton G. <ashton.galloway@hpe.com>
@EmilyBonar EmilyBonar requested a review from ashtonG July 31, 2024 15:33
@EmilyBonar EmilyBonar enabled auto-merge (squash) July 31, 2024 16:00
@EmilyBonar EmilyBonar merged commit dab6978 into main Jul 31, 2024
82 of 95 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/show-run-code branch July 31, 2024 16:20
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Co-authored-by: Ashton G. <ashton.galloway@hpe.com>
(cherry picked from commit dab6978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants