Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Cluster Name title and change helm value #9775

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Jul 31, 2024

Ticket

Description

  • Add "Cluster Name" title as shown below
  • change helm chart additional_resource_managers[i].name to additional_resource_managers[i].cluster_name

Before (No title)
NoClusterNameTitle

After (with title)

WithClusterNameTitle

Test Plan

CI Passes.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 31, 2024
@amandavialva01 amandavialva01 requested a review from a team as a code owner July 31, 2024 19:29
@cla-bot cla-bot bot added the cla-signed label Jul 31, 2024
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6c36631
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66abc4641876aa0008536360

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.06%. Comparing base (fc8ac0b) to head (bdd5672).
Report is 13 commits behind head on main.

Files Patch % Lines
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9775      +/-   ##
==========================================
- Coverage   54.12%   49.06%   -5.06%     
==========================================
  Files        1257     1082     -175     
  Lines      154854   141696   -13158     
  Branches     3487     3485       -2     
==========================================
- Hits        83810    69526   -14284     
- Misses      70898    72024    +1126     
  Partials      146      146              
Flag Coverage Δ
harness 43.25% <ø> (-29.37%) ⬇️
web 53.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/kubernetesrm/jobs.go 71.38% <ø> (-0.06%) ⬇️
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% <0.00%> (ø)

... and 278 files with indirect coverage changes

helm/charts/determined/values.yaml Outdated Show resolved Hide resolved
@amandavialva01 amandavialva01 requested a review from a team as a code owner August 1, 2024 16:21
@amandavialva01 amandavialva01 changed the title chore: add Cluster Name title chore: add Cluster Name title and change helm value Aug 1, 2024
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adjusting

@amandavialva01 amandavialva01 merged commit 13ebf47 into main Aug 1, 2024
90 of 103 checks passed
@amandavialva01 amandavialva01 deleted the addClusterNameTitle branch August 1, 2024 18:41
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants