Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky test #9784

Merged
merged 1 commit into from
Aug 1, 2024
Merged

test: skip flaky test #9784

merged 1 commit into from
Aug 1, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Aug 1, 2024

Ticket

N/A

Description

Skips a test that has a nearly 30% fail rate. Will revisit ASAP to try to make this test more stable and un-skip it once more.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jesse-amano-hpe jesse-amano-hpe requested a review from a team as a code owner August 1, 2024 21:39
@cla-bot cla-bot bot added the cla-signed label Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit efe3751
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ac009abcb31a0009031095
😎 Deploy Preview https://deploy-preview-9784--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.72%. Comparing base (49c3fa0) to head (efe3751).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9784      +/-   ##
==========================================
- Coverage   54.04%   49.72%   -4.32%     
==========================================
  Files        1260      937     -323     
  Lines      155551   126218   -29333     
  Branches     3502     3502              
==========================================
- Hits        84067    62765   -21302     
+ Misses      71338    63307    -8031     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved there's a ticket or some reminder to de-flake this in the future.

@jesse-amano-hpe
Copy link
Contributor Author

jesse-amano-hpe commented Aug 1, 2024

Approved there's a ticket or some reminder to de-flake this in the future.

ET-678

@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) August 1, 2024 21:53
@jesse-amano-hpe jesse-amano-hpe merged commit 094c58b into main Aug 1, 2024
86 of 99 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/skip-flaky-test branch August 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants