Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't filter single runs in the comparison view #9789

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Aug 2, 2024

Ticket

ET-679

Description

This fixes an issue where single search runs were being filtered out of
the comparison view in runs view. We were erroneously applying a filter
to the search results.

Test Plan

  • in the search runs view, open the comparison view and switch to the details tab
  • filter the search results such that only runs of single searches are in the view
  • add rows to the selection
  • trials selected should appear in the details tab as the user updates the selection

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

This fixes an issue where single search runs were being filtered out of
the comparison view in runs view. We were erroneously applying a filter
to the search results.
@ashtonG ashtonG requested a review from a team as a code owner August 2, 2024 21:50
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 548c77f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ad54b8ba57f600080d9755
😎 Deploy Preview https://deploy-preview-9789--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashtonG ashtonG requested review from keita-determined and removed request for julian-determined-ai August 2, 2024 21:51
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.74%. Comparing base (fe14062) to head (548c77f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9789      +/-   ##
==========================================
- Coverage   54.05%   49.74%   -4.31%     
==========================================
  Files        1260      938     -322     
  Lines      155574   126271   -29303     
  Branches     3504     3506       +2     
==========================================
- Hits        84088    62816   -21272     
+ Misses      71340    63309    -8031     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.25% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...react/src/components/FilterForm/components/type.ts 96.95% <100.00%> (ø)
...components/RunFilterInterstitialModalComponent.tsx 97.85% <100.00%> (+0.27%) ⬆️
webui/react/src/utils/filterFormSet.ts 100.00% <100.00%> (ø)
webui/react/src/utils/flatRun.ts 99.15% <100.00%> (-0.09%) ⬇️

... and 323 files with indirect coverage changes

@ashtonG ashtonG added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Aug 5, 2024
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashtonG ashtonG merged commit cdbbedd into main Aug 5, 2024
88 of 101 checks passed
@ashtonG ashtonG deleted the bug/ET-679/no-compare-filter branch August 5, 2024 20:36
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants