ci: label make slurmcluster instances for cloud spend [CM-405]
#9792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9792 +/- ##
=======================================
Coverage 54.04% 54.05%
=======================================
Files 1260 1260
Lines 155574 155574
Branches 3503 3504 +1
=======================================
+ Hits 84085 84089 +4
+ Misses 71343 71339 -4
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. |
ioga
changed the title
make slurmcluster instances [CM-405]
ioga
requested review from
a team and
corban-beaird
and removed request for
a team
ioga
changed the title
make slurmcluster instances [CM-405]make slurmcluster instances for cloud spend [CM-405]
davidfluck-hpe
approved these changes
Aug 5, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-405
Description
make slurmclusterpipeline to set labels on the VM it creates and its diskAlso I've discovered that
make slurmclusterjob will stay pending when a background task to create a cluster failed, so I've fixed that. The job should now fail right away if that happens.Also I went to war with trailing whitespace in the circle config.
Test Plan
Do the VMs spawned by CI have that label?
Test run: https://app.circleci.com/pipelines/github/determined-ai/determined/59112/workflows/bd2dfd65-498c-46be-a01f-908aefa48a05/jobs/2836426
Checklist
docs/release-notes/See Release Note for details.