-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add editor project restricted role and testing [DET-10428] #9796
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9796 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 1260 1260
Lines 155574 155574
Branches 3503 3504 +1
=======================================
+ Hits 84091 84092 +1
+ Misses 71337 71336 -1
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ticket
DET-10428
Description
Adds pre-canned Editor Project Restricted role, which has the same permissions as an Editor without the ability to create or update projects.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.