Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkpoint table action menu shouldn't vanish on polling [ET-277] #9812

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Aug 12, 2024

Ticket

ET-277

Description

Test Plan

With the flat runs flag off, go to the Checkpoints tab of a single trial experiment. There must be at least one checkpoint in the table for testing purposes.

  • click the overflow icon at the far right of a table row to pull up the action menu for that checkpoint
  • wait, do not click anything for ~10 seconds
  • the action menu should still be visible
  • test both the register and delete checkpoint actions to confirm that they still work as expected

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 50.14%. Comparing base (91d0b67) to head (0990695).
Report is 6 commits behind head on main.

Files Patch % Lines
.../pages/ExperimentDetails/ExperimentCheckpoints.tsx 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9812      +/-   ##
==========================================
- Coverage   54.38%   50.14%   -4.24%     
==========================================
  Files        1261      938     -323     
  Lines      155770   126444   -29326     
  Branches     3540     3540              
==========================================
- Hits        84711    63411   -21300     
+ Misses      70921    62895    -8026     
  Partials      138      138              
Flag Coverage Δ
harness ?
web 53.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../pages/ExperimentDetails/ExperimentCheckpoints.tsx 13.73% <0.00%> (-0.24%) ⬇️

... and 323 files with indirect coverage changes

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0990695
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66bcf111bbcbe7000859dbfc
😎 Deploy Preview https://deploy-preview-9812--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot reproduce the bug in the latest main.
how can i reproduce it?

@EmilyBonar
Copy link
Contributor Author

cannot reproduce the bug in the latest main. how can i reproduce it?

you need to be on the experiment details page for a single trial experiment. the one that you linked looks to be multi-trial

@EmilyBonar EmilyBonar force-pushed the emilybonar/dropdown-menu-longevity branch from ad54378 to 2657f05 Compare August 14, 2024 15:20
@EmilyBonar EmilyBonar merged commit c0ca659 into main Aug 15, 2024
82 of 95 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/dropdown-menu-longevity branch August 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants