-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix torch version to 2.2.2 for intel Mac [MD-503] #9821
Conversation
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9821 +/- ##
==========================================
- Coverage 54.29% 54.27% -0.03%
==========================================
Files 1261 1261
Lines 155642 155642
Branches 3536 3535 -1
==========================================
- Hits 84510 84468 -42
- Misses 70994 71036 +42
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. |
Docsite preview being generated for this PR. |
4 similar comments
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
3042e4a
to
29fa78b
Compare
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on my intel mac and was able to build where I couldn't previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't have an Intel Mac to see if make -C harness check
works locally.
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
Ticket
MD-503
Description
https://hpe-aiatscale.slack.com/archives/CSG3W08JY/p1723649552010439
Support for PyTorch on Intel Mac deprecated. The highest version it can go is 2.2.2.
Solution: Set up PyTorch 2.2.2 specifically for Intel MAC while keeping other environments using 2.3.0.
Test Plan
CI passes.
make all
andmake -C harness check
don't have error on an Intel MAC.Checklist
docs/release-notes/
See Release Note for details.