Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix torch version to 2.2.2 for intel Mac [MD-503] #9821

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Aug 14, 2024

Ticket

MD-503

Description

https://hpe-aiatscale.slack.com/archives/CSG3W08JY/p1723649552010439

As new Intel Mac’s are no longer produced and with time fewer will remain in use, we will be stopping testing and eventually building macOS x86_64 binaries after the release 2.2.0 is complete (mid January 2024). We will not be producing macOS x86_64 binaries for Release 2.3.0.

Support for PyTorch on Intel Mac deprecated. The highest version it can go is 2.2.2.

Solution: Set up PyTorch 2.2.2 specifically for Intel MAC while keeping other environments using 2.3.0.

Test Plan

CI passes.
make all and make -C harness check don't have error on an Intel MAC.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Aug 14, 2024
@determined-ci determined-ci requested a review from a team August 14, 2024 16:56
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 29fa78b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66bced9188c7930008165feb

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.27%. Comparing base (79ffa52) to head (29fa78b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9821      +/-   ##
==========================================
- Coverage   54.29%   54.27%   -0.03%     
==========================================
  Files        1261     1261              
  Lines      155642   155642              
  Branches     3536     3535       -1     
==========================================
- Hits        84510    84468      -42     
- Misses      70994    71036      +42     
  Partials      138      138              
Flag Coverage Δ
backend 44.89% <ø> (-0.08%) ⬇️
harness 72.61% <ø> (ø)
web 53.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@jgongd jgongd changed the title Jgong/intel mac on py38 support torch 2.2.2 chore: intel mac on py38 support torch <= 2.2.2 Aug 14, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

4 similar comments
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@jgongd jgongd force-pushed the jgong/intel-mac-on-py38-support-torch-2.2.2 branch from 3042e4a to 29fa78b Compare August 14, 2024 17:46
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

1 similar comment
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my intel mac and was able to build where I couldn't previously.

@jgongd jgongd marked this pull request as ready for review August 14, 2024 18:21
@jgongd jgongd requested a review from a team as a code owner August 14, 2024 18:21
Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have an Intel Mac to see if make -C harness check works locally.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@jgongd jgongd changed the title chore: intel mac on py38 support torch <= 2.2.2 chore: fix torch version to 2.2.2 for intel mac Aug 14, 2024
@jgongd jgongd merged commit 9548790 into main Aug 14, 2024
91 of 104 checks passed
@jgongd jgongd deleted the jgong/intel-mac-on-py38-support-torch-2.2.2 branch August 14, 2024 20:15
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@jgongd jgongd changed the title chore: fix torch version to 2.2.2 for intel mac chore: fix torch version to 2.2.2 for intel Mac [MD-503] Aug 15, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

1 similar comment
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants