Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts passed to Context.Eval do not inherit variables in scope. #15

Closed
deuill opened this issue Jan 26, 2016 · 1 comment
Closed

Scripts passed to Context.Eval do not inherit variables in scope. #15

deuill opened this issue Jan 26, 2016 · 1 comment
Assignees
@deuill
Labels
bug

Comments

@deuill
Copy link
Owner

deuill commented Jan 26, 2016

As such, it is currently impossible to Context.Bind a variable and use it with Context.Eval. This is related to this hack, since closures in PHP need their scope passed in explicitly.
@deuill deuill added the bug label Jan 26, 2016
@deuill deuill self-assigned this Jan 26, 2016
@deuill deuill mentioned this issue Jan 26, 2016
Merged
@deuill
Copy link
Owner Author

deuill commented Jan 26, 2016

Fixed by #16.

@deuill deuill closed this as completed Jan 26, 2016
borancar pushed a commit to borancar/go-php that referenced this issue Dec 1, 2019
Merged in bug/remove-session-logs (pull request deuill#15)
7d83f53 
bug/remove-session-logs - Quote marks stops regex working for delete

Approved-by: Darren Izzard <darren.izzard@antstream.com>
Approved-by: James Stow <james.stow@antstream.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deuill deuill

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deuill