Context: Fix variable scoping issues for Eval
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Context.Eval` relied on Zend's `zend_eval_script` function for executing arbitrary strings. Unfortunately, the above contains a curious bit of functionality where the string passed is prepended with a `return` statement depending on whether or not a zval is passed for writing the return value. This, of course breaks all but the simplest scripts, as we always write the return value to a zval (whether the user calling `Context.Eval` is to use the return value is another matter entirely). This commit changes the implementation to a more direct (and therefore more controllable) approach. Some tests have been changed to cover this bug.
The `Context.Eval` function invariably creates a `Value` which may or may not end up being passed to the caller. Keep a reference to the value and destroy it during `Context.Destroy` at the latest.
|
This closes #15. |
deuill
added a commit
that referenced
this pull request
Jan 26, 2016
Context: Fix variable scoping issues for `Eval`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Context.Evalrelied on Zend'szend_eval_scriptfunction for executing arbitrary strings. Unfortunately, the above contains a curious bit of functionality where the string passed is prepended with areturnstatement depending on whether or not a zval is passed for writing the return value.This, of course breaks all but the simplest scripts, as we always write the return value to a zval (whether the user calling
Context.Evalis to use the return value is another matter entirely).This commit changes the implementation to a more direct (and therefore more controllable) approach. Some tests have been changed to cover this bug.