Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): added introductory documentation (#1765) #1785

Merged
merged 3 commits into from
May 19, 2024

Conversation

momaqbol
Copy link
Member

@momaqbol momaqbol commented May 1, 2024

  • deprecate old components

  • improve markdown docs and display it in storybook

  • improve SEO and add fivicon for devlaunchers

* deprecate old components

* improve markdown docs and display it in storybook

* improve SEO and add fivicon for devlaunchers
@momaqbol momaqbol requested a review from a team as a code owner May 1, 2024 17:39
Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 075dd76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* icons and formatting

* added mdx and updated stories

* added padding to dialog to match figma. Removed instabook

* Added Typography, but still not OSWALD

* Resizing header

* Created share btn

* Updated MDX, and removed custom share button, added share Icon to share btn

* Figma designs added and description with /**

* made everything jsdoc
@momaqbol momaqbol requested a review from pyxld-kris as a code owner May 1, 2024 22:59
Copy link

cloudflare-workers-and-pages bot commented May 1, 2024

Deploying platform--website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 075dd76
Status:🚫  Build failed.

View logs

* resolve progressBar issues

* progress bar preview

* progreesbar

* progress bar with storybook

* description not working

* description not working and not autogenerated

* encapsulated props

* encapsulated props but description is still not working

* new changes

* use the same props coming from radix

* linked the progressbar element to its related text to improve accessiblity

see: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/progressbar_role#examples

* install @radix-ui/react-progress

---------

Co-authored-by: Enjoy2Live <iMohammedMaqbol@gmail.com>
@momaqbol momaqbol merged commit b6aadb7 into master May 19, 2024
5 of 8 checks passed
@dev-launchers-flux
Copy link
Collaborator

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants