-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile-Picture-Backend-Integration-FinalChanges #1809
Profile-Picture-Backend-Integration-FinalChanges #1809
Conversation
…nchers/dev-launchers-platform into wimaan3/profile-picture-backend-final
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the styling implementation, looks fine. I'll let someone else review the agent.ts logic, and approve.
Readded the comments in the useUserDataHook function
apps/user-profile/src/components/modules/OnboardingLandingPage/OnboardingLandingPage.js
Outdated
Show resolved
Hide resolved
I recommend squashing into 1 commit before merging. |
Is it possible to do this on github because I believe it needs the
repository to allow squashing?
…On Mon, Jun 3, 2024 at 8:34 PM chungthuang ***@***.***> wrote:
I recommend squashing into 1 commit before merging.
—
Reply to this email directly, view it on GitHub
<#1809 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4ELLC3RJ2WG3X7MJEUSSU3ZFUYSRAVCNFSM6AAAAABIVQQFJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGUZDCNJWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Usually I run |
Added error checking for first/last name validation
Here is the final implementation for the profile picture backend integration. This is after my meeting with Chung-Ting and Wolfgang about the errors I was facing.