Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile-Picture-Backend-Integration-FinalChanges #1809

Closed

Conversation

wimaan3
Copy link
Contributor

@wimaan3 wimaan3 commented Jun 3, 2024

Here is the final implementation for the profile picture backend integration. This is after my meeting with Chung-Ting and Wolfgang about the errors I was facing.

@wimaan3 wimaan3 requested review from a team as code owners June 3, 2024 00:49
Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 7941ed2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@judeamos judeamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the styling implementation, looks fine. I'll let someone else review the agent.ts logic, and approve.

Readded the comments in the useUserDataHook function
@chungthuang
Copy link
Contributor

I recommend squashing into 1 commit before merging.

@wimaan3
Copy link
Contributor Author

wimaan3 commented Jun 4, 2024 via email

@chungthuang
Copy link
Contributor

Is it possible to do this on github because I believe it needs the repository to allow squashing?

On Mon, Jun 3, 2024 at 8:34 PM chungthuang @.> wrote: I recommend squashing into 1 commit before merging. — Reply to this email directly, view it on GitHub <#1809 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4ELLC3RJ2WG3X7MJEUSSU3ZFUYSRAVCNFSM6AAAAABIVQQFJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGUZDCNJWGI . You are receiving this because you authored the thread.Message ID: @.>

Usually I run git rebase -i <branch to merge to>. But you can also give this a try https://docs.github.com/en/desktop/managing-commits/squashing-commits-in-github-desktop.

Added error checking for first/last name validation
@wimaan3 wimaan3 closed this Jun 5, 2024
@chadcrotchett chadcrotchett deleted the wimaan3/profile-picture-backend-final branch November 14, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants